build(deps): unblock TypeScript 7 API generation - #1610
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (16)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe webapp switches to TypeScript 7 and a prerelease OpenAPI generator. Generated API code adds explicit types, exports client metadata types, sets a root base URL, updates parameter slot construction, and reformats transformers. ChangesTypeScript 7 toolchain and generated API
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR standardizes the TypeScript and API-generation toolchain while preserving the existing generated client behavior. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The PR removes the webapp TypeScript 6 dependency and typescript7 alias, pins the exact openapi-ts prerelease, switches build and typecheck scripts to tsc, and commits the regenerated API client. These changes satisfy the coding requirements in issue Full details: Out of Scope Changes checkExplanation The changes remain within the linked issue scope. The generated API updates, formatting changes, type annotations, metadata exports, documentation update, and changeset support the TypeScript 7 and API generation toolchain migration. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 10 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧩 Storybook Preview
|
📚 Documentation Preview
|
Description
Unifies the workspace on TypeScript 7.0.2 by removing the webapp's TypeScript 6 dependency and
typescript7alias. API generation moves to an exact@hey-api/openapi-tsprerelease snapshot whose renderer no longer depends on the TypeScript compiler API, so the webapp can use the normaltsccommand everywhere.The generated client is committed in full because the new renderer changes canonical formatting, declaration order, and some generated helper types. Its public operation and model exports remain intact, and a second destructive generation produced byte-identical output.
Dependency choice
Stable
@hey-api/openapi-ts@0.99.0still fails with TypeScript 7 because it reads the compiler API that the native compiler package does not expose (hey-api/hey-api#4235). This PR pins0.0.0-next-20260824173136exactly—rather than following the mutablenexttag—and records its integrity inbun.lock. The snapshot is prerelease software; the exact pin, committed generated output, and CI drift check bound that risk until the upstream work reaches a stable release.No operator or user action is required.
Fixes #1593
Unblocks #1466
How to test
bun install --frozen-lockfilebun run generate:api:application-server:clientand confirmwebapp/src/apiremains unchangedbun run typecheckbun run test:webappbun run build:webappbun run verifyChecklist
Summary by CodeRabbit
New Features
Improvements